search

MariusRumpf / node-lifx

Node.js implementation of the LIFX LAN protocol :bulb:
MIT License
144 stars 28 forks source link

add the lifx mini color product #64

Closed jvanaert closed 6 years ago

codecov-io commented 6 years ago

Codecov Report

Merging #64 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #64   +/-   ##
=======================================
  Coverage   60.43%   60.43%           
=======================================
  Files          45       45           
  Lines        1418     1418           
  Branches      226      226           
=======================================
  Hits          857      857           
  Misses        561      561

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9a459b6...c314770. Read the comment docs.

MariusRumpf commented 6 years ago

Might have made more sense to use the complete file, from LIFX themselves: https://github.com/LIFX/products/blob/master/products.json this seems to include three different id for the mini lights.

ristomatti commented 6 years ago

@MariusRumpf Hah true. Sorry didn't remember it was based on an actual file. Well I guess that's easy to fix. But now that you're active, please check the other PR's also.