Mariusz89B / script.mtvguide

m-TVGuide, a completely free Kodi add-on with support for electronic tvguide (EPG). Allows streaming content from licensed television provider services and M3U playlists.
GNU Affero General Public License v3.0
29 stars 5 forks source link

EPG again #24

Closed nalewkababuni closed 1 year ago

nalewkababuni commented 1 year ago

Today i updated Kodi to 19.5, have latest mtvguide 9.9.634 installed. The problem is epg again. I have auto time zone selected in settings, but the epg on the Kodi is +1 hour. I set manual time zone but nothing changed, still +1 hour. I don't think its because new version of Kodi, because i saw this error before updating to 19.5 and mtvguidemtvguide-9.9.633_v2. It was strange, because I was downloading tv show on 25.12 and epg was ok, on the 26.12 it is not. I made a screenshot on 25.12 and it looks like one epg is over the second. I use Windows 10, Kodi 19.5, mtvguide 9.9.634 epg source:epg.ovh 2022-12-26_170135

Mariusz89B commented 1 year ago

@nalewkababuni Please try this version. https://github.com/Mariusz89B/script.mtvguide/releases/tag/9.9.635_v2

Use setting "Adjust to local timezone" then reinitilize the guide.

https://github.com/Mariusz89B/script.mtvguide/commit/3aab06e4306f0ccb15f15eb248363e7b6757b47b

nalewkababuni commented 1 year ago

No, still the same. I noticed the epg overlapping starts on the 25.12 at 7:00 and ends at 00:00. From 00:00 26.12 epg is +1 hour. Maybe there is something wrong in epg itself?

https://user-images.githubusercontent.com/30936261/209584921-d6363fd1-669c-4c78-9955-f08e035c273a.mp4

Mariusz89B commented 1 year ago

@nalewkababuni Have you reinitialized the guide? Context menu - Reinitialize guide

But to answer your question, yes it seems to be some issues with the epg itself.

EDIT: Another release with some fixes. https://github.com/Mariusz89B/script.mtvguide/releases/tag/9.9.635_v3

nalewkababuni commented 1 year ago

After installing v3 still the same. Yes, i have reinitialized the guide.

Mariusz89B commented 1 year ago

@nalewkababuni I'v made some changes in v5 on how m-TVGuide handles timezones,

Just to clarify m-TVGuide different timezone settings.

1. Auto timezone

Automatically adjusts timezone to value provided in the EPG file.

eg.

  1. In this case below 19:30 +01:00 will result in 20:30.
<programme start="20221226193000 +0100" stop="20221226200500 +0100" channel="TVP 1">
     <title lang="pl">Wiadomości</title>
 </programme>
  1. But if a timezone is missing and the EPG auto correct the timezone itself then m-TVGuide will only read the timestamp resulting in 19:30.
<programme start="20221226193000" stop="20221226200500" channel="TVP 1">
    <title lang="pl">Wiadomości</title>
 </programme>

2. Adjust to local timezone

Adjust parsed date to local timezone. This will ignore the timezone found in the EPG file and set a timezone from system settings and correct itself for summer/winter time.

<programme start="20221226193000 +0100" stop="20221226200500 +0100" channel="TVP 1">
     <title lang="pl">Wiadomości</title>
 </programme>

For timezone Poland/Warsaw this will add +01:00 to the EPG and result in 20:30.

3. Manually adjust timezone

Manually set a timezone value.

Manually adjust timezone have been fixed in 9.9.635

4. Result

I have tested https://epg.ovh/pl.gz with manually setting timezone to GMT 00:00 in settings, and the time is now displaying correctly.

image

screenshot00000

https://github.com/Mariusz89B/script.mtvguide/releases/tag/9.9.635_v5 https://github.com/Mariusz89B/script.mtvguide/commit/69ddebbe7261f628282146aaa195b8b4ea426cd9

nalewkababuni commented 1 year ago

I confirm. Manually setting timezone to GMT 00:00 works. Thanks.

Mariusz89B commented 1 year ago

I confirm. Manually setting timezone to GMT 00:00 works. Thanks.

I've got confirmation from @sky02 that an update broke the epg yesterday.

Screenshot_20221227_161607_Discord

nalewkababuni commented 1 year ago

Tak, plar używam, ale zostaje przy nim, bo potrzebuję archiwum, a z tym manualnym ustawieniem działa ok.

Mariusz89B commented 1 year ago

https://github.com/Mariusz89B/script.mtvguide/commit/8751c031e93b3e0e80f8d9531f42324c2a5a6806