Extrude fails sometimes due to Dir mode

MariwanJ / Design456

An attempt to create Direct Modeling workbench for FreeCAD

GNU General Public License v3.0

49 stars 6 forks source link

Extrude fails sometimes due to Dir mode #20

Closed MariwanJ closed 3 years ago

MariwanJ commented 3 years ago

Some surfaces needs 'Custom' others 'Normal' I still didn't figure out why and when?

MariwanJ commented 3 years ago

The same could happen to the Smart Extrude. It is better to give visual possibility to fix that .. User should fix that. in python is not easy to find why .. at least for now

MariwanJ commented 3 years ago

issue fixed When normalAt is not (1,0,0), (0,1,0) or (0,0,1) and are decimals, the "custom" must be used. the Dir will be the normalAt value and that solves the problem both for normal Extrude (old tool) and the Smart Extrude

luzpaz commented 3 years ago

FYI, it's instructive to add the commit(s) associated with the fix (for posterity) when closing a ticket.

MariwanJ commented 3 years ago

explanation is added.