search

MariwanJ / Design456

An attempt to create Direct Modeling workbench for FreeCAD
GNU General Public License v3.0
50 stars 5 forks source link

Design456_SmartExtrudeRotate rotation is wrong #68

Open MariwanJ opened 2 years ago

MariwanJ commented 2 years ago

Rotation of the disc is totally wrong and it varies based on the face location.

MariwanJ commented 2 years ago

The bug is hard to solve. Seems to be in the widget itself. needs more work to figure out how it should be fixed. And maybe the tool needs to get more option to allow the direction of the rotation.

MariwanJ commented 2 years ago

Many bugs are fixed. This tool might need improvements. At the moment, I leave it as it is.. Maybe I will come back to fix and improve other things in this tool. 621d62ea183272243b2feec8ae2a48afcdc400f1

MariwanJ commented 2 years ago

still there are cases where this is wrong More testing needed and case should be clear where it fails.

MariwanJ commented 2 years ago

Many bugs are fixed. 5252721bf82eee02c6ff9ccbe2835082698886f0 But unfortunately, the direction of the wheel is not correct if the face has an angle.

MariwanJ commented 2 years ago

Still I don't know how to calculate the Axis of rotation for the wheel. I tried many things but still not OK. For extrusion it is ok . but for the revolve the rotation of the wheel is wrong. Don't know how to calculate that.