search

MariwanJ / Design456

An attempt to create Direct Modeling workbench for FreeCAD
GNU General Public License v3.0
49 stars 6 forks source link

Update package.xml to correct branch and classname #70

Closed chennes closed 2 years ago

chennes commented 2 years ago

The classname you use in InitGui.py is Design456, not Design456Workbench. Also, your primary branch is called main, not master.

MariwanJ commented 2 years ago

Thanks. But still I don't admit that I have any release version. So, should still the version be there?

chennes commented 2 years ago

Yes -- just use "0.0.1-alpha" or something -- if it's left empty, then users installing using ZIP files (if they don't have git installed) will never see any updates to your Addon. You have to increment that version number if you want them to get those. Obviously for users with git installed that doesn't matter, but we try to support non-git installation as well.

MariwanJ commented 2 years ago

That is the problem. I regularly update my WB. Sometimes are just small bug-fixing. Stepping that will be a headache for me. For those uses Design456, they need to know that there is no release version. I am developing the core-tool. Since I face trouble with OCC so I haven't done all my base tools. So, I ask you to remove the version in the patch and I will add it.. please Waiting for your change. thanks.

chennes commented 2 years ago

You are under no obligation to step the version number on each minor fix -- but if you have a blank version number, users who do not have git installed will never see your changes at all. At least by including a version number that you occasionally update those users will be able to pull the latest version. If you aren't comfortable assigning a semantic version, consider just using a date using the CalVer style: https://calver.org/