Mark-H / StatusPage

A simple, standalone, PHP status page.
8 stars 3 forks source link

Table Sorting Broken #1

Open amdbuilder opened 11 years ago

amdbuilder commented 11 years ago

The table sorting is broken, and no longer shows offline servers first. In the case of large check lists, sorting will be more important

Mark-H commented 11 years ago

It was never functional on my install, so I took it out completely :p see my last commits (assuming I pushed it). Op 14 okt. 2012 21:36 schreef "amdbuilder" notifications@github.com het volgende:

The table sorting is broken, and no longer shows offline servers first. In the case of large check lists, sorting will be more important (ex: http://status.skytoaster.com/)

— Reply to this email directly or view it on GitHubhttps://github.com/Mark-H/StatusPage/issues/1.

amdbuilder commented 11 years ago

It took some tinkering to get working, perhaps this will help: http://tablesorter.com/docs/example-ajax.html and http://tablesorter.com/docs/example-empty-table.html

The problem in short was triggering the table sorter again after the reload. I'll tinker more later.

Mark-H commented 11 years ago

I think we need to figure out a way to separate between different implementations. :P Op 14 okt. 2012 21:50 schreef "amdbuilder" notifications@github.com het volgende:

It took some tinkering to get working, perhaps this will help: http://tablesorter.com/docs/example-ajax.html and http://tablesorter.com/docs/example-empty-table.html

The problem in short was triggering the table sorter again after the reload. I'll tinker more later.

— Reply to this email directly or view it on GitHubhttps://github.com/Mark-H/StatusPage/issues/1#issuecomment-9425070.

amdbuilder commented 11 years ago

There should be much in the way of differences, outside of difference preferences in sort order (offline servers first/last) and javascript enabled sorting. That being said I could see attempting to expand the per check details similar to Pingdom's public monitoring.

The overview details are great for a basic "noc", but when investigating problems a detailed overview can be helpful.

Mark-H commented 11 years ago

I was talking more generally speaking, not just this table.

Assuming "data.php" and the rest of the /lib/ dir is the Status "library", and index.php is an example implementation for a status page, there needs to be a way for me to build my implementation for this specific status page which has no need for table sorting, whereas your implementation most definitely does seeing the different kind of overview.

In terms of sorting offline servers/services first, that definitely makes sense if the implementation contains a table that is not sorted on something arbitrary (like drilling down into the infrastructure hierarchy, eg: site / domain dns / hosting server). But what about a status page like https://status.github.com/ where the uptime monitoring is just a green or red dot in the header?

In other words, we need to find a way to decouple the implementation from the library so it can be used for different purposes without colliding in priorities. (Yes, I'll OS this when it matures a bit).

I can imagine an option in the config for listing offline checks first would make sense though.

amdbuilder commented 11 years ago

Ok, I follow now... Perhaps we could implement an output setting with a few likely suspects? Output to tables, unordered lists and divs? The alternative would be to implement some form of template system for the output from data.php.