search

Mark-Tomlinson / markup-by-attribute-for-woocommerce

Price markup by attribute term for WooCommerce
GNU General Public License v3.0
3 stars 3 forks source link

Add support of other currencies #1

Closed Zjadlbymcos closed 6 years ago

Zjadlbymcos commented 6 years ago

I live in Poland. Our currency symbol is "zł" or "PLN". Can you add support for string currencies? Not all currencies have symbol like $ or €.

Mark-Tomlinson commented 6 years ago

I can't decide whether I should add "zł" and "PLN" to the existing edit or if I should remove edits for currency all together.

 

Do you have a preference?

 

-- Mark Tomlinson "I am not a trouble maker; I'm a catalyst for change."

   

Sent: Wednesday, September 12, 2018 at 4:24 PM From: Zjadlbymcos notifications@github.com To: Mark-Tomlinson/markup-by-attribute-for-woocommerce markup-by-attribute-for-woocommerce@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: [Mark-Tomlinson/markup-by-attribute-for-woocommerce] Add support of other currencies (#1)

I live in Poland. Our currency symbol is "zł" or "PLN". Can you add support for string currencies? Not all currencies have symbol like $ or €.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

Zjadlbymcos commented 6 years ago

If my opinion matters I think you should let enduser decide what prefix or postfix he wants. Even if that will be "lama".

But the best option will be to use properties from WooCommerce. There are option to choose beetween currencies and position (prefix, postfix). There's no need to duplicate this feature in your plugin.

WooCommerce -> Settings -> General -> Currency options Currency options

Mark-Tomlinson commented 6 years ago

And that is exactly why your opinion matters.

 

I'll set it up to use the WooCommerce currency options and get a new version out probably by the end of next week.  

-- Mark Tomlinson "I am not a trouble maker; I'm a catalyst for change."

   

Sent: Thursday, September 13, 2018 at 2:32 AM From: Zjadlbymcos notifications@github.com To: Mark-Tomlinson/markup-by-attribute-for-woocommerce markup-by-attribute-for-woocommerce@noreply.github.com Cc: "Mark Tomlinson" mt2@technologist.com, Comment comment@noreply.github.com Subject: Re: [Mark-Tomlinson/markup-by-attribute-for-woocommerce] Add support of other currencies (#1)

If my opinion matters I think you should let enduser decide what prefix or postfix he wants. Even if that will be "lama".

But the best option will be to use properties from WooCommerce. There are option to choose beetween currencies and position (prefix, postfix). There's no need to duplicate this feature in your plugin.

WooCommerce -> Settings -> General -> Currency options

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

Mark-Tomlinson commented 6 years ago

Still working on this. The change was fairly easy, but I need to do some extensive testing. Will have it out in a few days.

Mark-Tomlinson commented 6 years ago

I've just released version 2.4. It uses the WooCommerce currency settings. Give it a shot and let me know if it works for you.

https://wordpress.org/plugins/markup-by-attribute-for-woocommerce/.

Zjadlbymcos commented 5 years ago

It works great :) Thank you very much for your work!