search

Mark1Z / ckeditor5-indent-text

Text indenting feature for CKEditor 5.
10 stars 6 forks source link

When I import this using an inline editor, it makes it so that the toolbar cannot be sticky #3

Open nickmanning214 opened 5 years ago

nickmanning214 commented 5 years ago

Just a quick heads up - I intended to use this package with my custom implementation of CKEditor using the inline editor (@ckeditor/ckeditor5-editor-inline/src/inlineeditor). With the Inline Editor, the toolbar should be sticky and scroll with the user.

However, including this package in the bundle using import IndentTextPlugin from 'ckeditor5-indent-text/src/indent-text' caused the toolbar to sit at the bottom of the editable area rather than be sticky.

All I had to do in order to trigger this bug was to import the package. Even if I didn't put the plugin in the plugins array, it would still trigger the bug.

nickmanning214 commented 5 years ago

Such a simple package, I decided to look into this a bit. Turns out importing ButtonView causes this to happen. If you do not import ButtonView in index-text-ui.js, the bug is gone.