Mark2Mark / variable-font-preview

https://markfromberg.com/projects/variable-font-preview-3/
8 stars 0 forks source link

Ability to change font size and adjust window #21

Closed Mark2Mark closed 1 year ago

Mark2Mark commented 1 year ago

Originally reported by @gorjious in #18 but that issue was highjacked with another issue, so I reopen it here again.


"I find it difficult to use VFP on a 13in laptop. As the top preview panel is linked to the bottom preview panel, there is too much loss in screen real-estate. The separate preview panel helps somewhat in that regard but it still adds too much above the displayed glyphs, and resizing the window causes the font size to be reduced as well.

Even with using an external monitor, it becomes difficult to find a balance between the various windows (all the more difficult as VFP is always displayed on top of the main app).

I think perhaps the simplest solution is to allow users to the change the displayed font size either by pinch-zoom, slider (on preview window or hidden in double click option menu), as well as, the ability to resizing the preview window without affecting the font size (or some other way that reduces the amount of addtional whitespace)."

75th commented 1 year ago

I suspect that @gorjious's "it still adds too much above the displayed glyphs" is a reference to the issue this was split from; I don't think I hijacked it at all. Agreed that we should still be able to change the font size independently, but I think the original reporter will be a happier camper already.

Mark2Mark commented 1 year ago

Don’t get me wrong, please don’t be offended. I just want to have my repository clean and changing the font size is a different thing. Hence I just separated the issues so that I can work well with it. The other issue started to be about different things, and it is hard to handle that if it is all in one issue.

Even this one issue shows several problems that need to be adressed. For example

As the top preview panel is linked to the bottom preview panel,

This is odd to me, as the top preview panel is not linked at all to the bottom panel since almost 2 years. So I suspect that @gorjious might not have gotten any updates since a while. Which is very curious, if that is really the case.

I think the original reporter will be a happier camper already.

That would be nice. But I cannot guess. I will need confirmation. Otherwise I can set this on low priority and wait if more user request it. Changing the font size additionally to the the current scaling adds a lot of overhead, so it needs to be well founded in order to invest the time, effort and testability.

But as always, thanks for your input!

Mark2Mark commented 1 year ago

But maybe I misunderstood the OP’s description and it might be solved as you say with the closing of the other issue #18

I will close it now. Feel free to re-open. :)

gorjious commented 1 year ago

Just got a new computer so adding back plugins. Will test on the new and old setups and report back.

Mark2Mark commented 1 year ago

If you need help transferring your licenses, please let me know via email :)

Thanks everyone for all your help!