Mark7888 / steelseries-sonar-py

Python package to controll SteelSeries Sonar
MIT License
13 stars 3 forks source link

fixed Style Guide issues, streamer mode detection errors, and removed unnecessary code. #8

Closed cookie0o closed 1 month ago

cookie0o commented 1 month ago
  • is_streamer_mode

function is now called "is_streamer_mode" and in the Sonar class.

Mark7888 commented 1 month ago

Yes, this gonna be good, but remove the self inside the function call. You only need the self variable when defining it def is_streamer_mode(self):, when calling it with self.is_streamer_mode(), the object itself provides the value of self.

Here the answers explain why: https://stackoverflow.com/questions/18679803/python-calling-method-without-self

cookie0o commented 1 month ago

Yes, this gonna be good, but remove the self inside the function call. You only need the self variable when defining it def is_streamer_mode(self):, when calling it with self.is_streamer_mode(), the object itself provides the value of self.

Here the answers explain why: https://stackoverflow.com/questions/18679803/python-calling-method-without-self

I´m actually aware of this behavior looks like i missed it while fixing the self. / Sonar. call

Mark7888 commented 1 month ago

Nice. I'm merging this now, and will take one more look at it Saturday, (when I can test it on my Windows machine), and then will publish a release.