Getting better, but the function `streamer_mode_status` still has two minor problems. - Githubissues

Mark7888 / steelseries-sonar-py

Python package to controll SteelSeries Sonar

MIT License

13 stars 3 forks source link

Getting better, but the function `streamer_mode_status` still has two minor problems. #9

Closed cookie0o closed 1 month ago

cookie0o commented 1 month ago

          Getting better, but the function `streamer_mode_status` still has two minor problems.

Place it inside the Sonar class, in my opinion, it belongs there.
It returns a boolean (True or False). Rename it to represent an action of getting the state of streamer mode, like is_streamer_mode_enabled or just is_streamer_mode.

Originally posted by @Mark7888 in https://github.com/Mark7888/steelseries-sonar-py/pull/8#pullrequestreview-2088857636