MarkAusten / TDHelper

GUI for Trade Dangerous and EDDBlink
MIT License
7 stars 4 forks source link

Further fixes to option interactions. #17

Closed eyeonus closed 6 years ago

eyeonus commented 6 years ago

1: 'item' should turn on 'station'.


2: 'skipvend' and 'solo' should only turn off the options 'shipvend', 'upvend', and also, in the latter case, 'listings', and should not touch anything else.

Since turning off those three triggers the toggling of their parent options, we need to make sure the parent options stay on in the event that 'all' or 'clean' are enabled, when any of the three are turned off, by running the SetAll() immediately afterwards.


I would've done this in the last PR if I could see the results. Sadly, I still can't get the thing to successfully compile on my machine.

MarkAusten commented 6 years ago

Not sure why you can't get the code to compile, all the dependencies are handled by NuGet and should install automatically.

eyeonus commented 6 years ago

No idea. Most recently, I got a compile succeeded message, but when I tried to run it, the program immediately exits with exit code 0.

MarkAusten commented 6 years ago

That is ....frustrating!

Are the x86 and x64 folders found in the Debug/Release folders? These contain the SQLite Interop libraries for SQLite and I did have trouble getting this to work initially.

eyeonus commented 6 years ago

They do indeed.

eyeonus commented 6 years ago

I'm still getting that unhandled exception on cmdr update with the latest beta, and none of the fields are getting updated, including the dropdown that's supposed to show the different ships- it still only contains "default".

MarkAusten commented 6 years ago

The trouble is that it works on my system with my profile and I really need to know what is different between your profile and mine. There's little or no useful information about the Companion API so unless you are willing to send me the last.json file from your EDCE folder to try out, there's little I can do except keep guessing.

eyeonus commented 6 years ago

TD Helper 2 https://drive.google.com/file/d/1zUq4KIfLwsjdFwwKSYybiz3EZqTTkVZp/view?usp=sharing

edce https://drive.google.com/file/d/1FPfCpg9fxx9qQiNi6ZBl-vjoZ9RFL9JN/view?usp=sharing

And the logs, just for good measure https://drive.google.com/file/d/1uEj7bpL1jNo8qH7mkUKffKJLrm-_HYB5/view?usp=sharing

eyeonus commented 6 years ago

One thing I can tell you about the cmdr profile weirdness, it does update the credits, insurance, and cargo capacity before it spits the error.

MarkAusten commented 6 years ago

Okay I can see the problem. In your profile the list of ships you own is returned as an array of ship objects. Here are the first few line of that part of the profile:

"ships": [ { "id": 0, "name": "CobraMkIII",

In my profile the list returned is an object where each ship is an object attached to a property whose name is the ship ID like this:

"ships": { "5": { "id": 5, "name": "Cutter",

Obviously I wrote the code to decode the object list and it crashes out on the array of ship objects in your profile.

I have no idea why the Companion API returns two different collections but it seems to do just that. I'll now have to figure out a way to deal with both collections.