MarkAusten / TDHelper

GUI for Trade Dangerous and EDDBlink
MIT License
7 stars 4 forks source link

[Regression] Saved output has extraneous text compared to TDH #29

Closed eyeonus closed 6 years ago

eyeonus commented 6 years ago

As I said when this was #27, this issue has NOT been fixed.

The issue is NOT about the discrepancy in the insurance calculation.

The issue is about TDH2 saving extraneous, useless lines that TDH did NOT save, which is a regression.

In the example below the extraneous lines are:

Command line: -u "S:\Elite Dangerous Programs\Trade Dangerous\trade.py" run --fr="Liu Bajara/Silva Terminal" --cap=36 --ins=156181 --cr=6811317 --ly=12.65 --empty=14.30 --loop-int=5 --loop --pad=SML? -vvv --hops=6 NOTE: Pruned 1087 origins too far from any end stations NOTE: Pruned 2650 origins too far from any end stations

As you can see in the examples, these lines ARE present in TDH2's Saved #1 and are NOT present in TDH's Saved #1.

Original bug report follows.

This is the exact same run returned by both TDH and TDH2 (TDH2's insurance calculation is wrong by exactly 1 credit, hence the one credit discrepancy in the Start CR and Final CR), then saved to #1:

The actual route is exactly the same in both cases, and have thus been replaced with ellipses.

TDH2 (saved_1.txt):

Command line: -u "S:\Elite Dangerous Programs\Trade Dangerous\trade.py" run --fr="Liu Bajara/Silva Terminal" --cap=36 --ins=156181 --cr=6811317 --ly=12.65 --empty=14.30 --loop-int=5 --loop --pad=SML? -vvv --hops=6
NOTE: Pruned 1087 origins too far from any end stations
NOTE: Pruned 2650 origins too far from any end stations
Liu Bajara/Silva Terminal -> Liu Bajara/Silva Terminal (score: 72221.245367)
Start CR:  6,655,136
Hops    :          6
Jumps   :         12
Gain CR :    418,644
Gain/Hop:     69,774
Final CR:  7,073,780

  Load from Liu Bajara/Silva Terminal (462ls, BMk:N, Pad:L, Plt:N, Shp:Y, Out:Y, Ref:Y):
.
.
.
  Unload at Liu Bajara/Silva Terminal (462ls, BMk:N, Pad:L, Plt:N, Shp:Y, Out:Y, Ref:Y) => Gain 58,140cr (1,615cr/ton) => 7,229,961cr
  ----------------------------------------------------------------------------
Finish at Liu Bajara/Silva Terminal (462ls, BMk:N, Pad:L, Plt:N, Shp:Y, Out:Y, Ref:Y) gaining 418,644cr (1,974cr/ton) => est 7,229,961cr total

TDH (saved_1.txt)

Liu Bajara/Silva Terminal -> Liu Bajara/Silva Terminal (score: 72221.245367)
Start CR:  6,655,135
Hops    :          6
Jumps   :         12
Gain CR :    418,644
Gain/Hop:     69,774
Final CR:  7,073,779
  Load from Liu Bajara/Silva Terminal (462ls, BMk:N, Pad:L, Plt:N, Shp:Y, Out:Y, Ref:Y):
.
.
.
  Unload at Liu Bajara/Silva Terminal (462ls, BMk:N, Pad:L, Plt:N, Shp:Y, Out:Y, Ref:Y) => Gain 58,140cr (1,615cr/ton) => 7,229,961cr
  ----------------------------------------------------------------------------
Finish at Liu Bajara/Silva Terminal (462ls, BMk:N, Pad:L, Plt:N, Shp:Y, Out:Y, Ref:Y) gaining 418,644cr (1,974cr/ton) => est 7,229,961cr total
MarkAusten commented 6 years ago

I beg your pardon, my mistake.

MarkAusten commented 6 years ago

Fixed I think.