search

MarkAusten / TDHelper

GUI for Trade Dangerous and EDDBlink
MIT License
7 stars 4 forks source link

Line separating ships in wrong place. #39

Closed eyeonus closed 6 years ago

eyeonus commented 6 years ago

The line separating the useless^H^H^H^H^H^H^H default ships from the ships I actually have is in the wrong place: image image

MarkAusten commented 6 years ago

You may think it is useless, but since others do not I'll be ignoring that useless opening statement.

Does the line appear in the incorrect position if you restart TDH2?

thanks.

eyeonus commented 6 years ago

Yes.

MarkAusten commented 6 years ago

Rats! It must be something to do with the first time it loads up everything. I'll investigate it further and see if I can't get it sorted out. It's very annoying.

Thanks for the confirmation.

eyeonus commented 6 years ago

What is the point of having all the ships anyway?

On Thu, Sep 13, 2018, 02:32 MarkAusten notifications@github.com wrote:

Rats! It must be something to do with the first time it loads up everything. I'll investigate it further and see if I can't get it sorted out. It's very annoying.

Thanks for the confirmation.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/MarkAusten/TDHelper/issues/39#issuecomment-420927683, or mute the thread https://github.com/notifications/unsubscribe-auth/ABpz4DhV5LJegnIhQ1I97UX9blx7PaGUks5uahgHgaJpZM4WmbT9 .

MarkAusten commented 6 years ago

For you, none at all. For me, well I use the owned ships as a "bookmark" to my owned ships and use the other list for "what-if' scenarios without my having to write down my ship settings and then reset them once I've done the what-if stuff.

Another commander I've been taking with uses the non-owned ships for doing trade calculations for other commanders with whom he plays Elite, meaning that he can do these without disturbing his own ship values.

I'd guess that you would probably be happy with a single nondescript entry (default) that could be used as you wished and in future I may make the whole ship thing work that way. In the settings there would be a choice of minimal, owned only, bare-ship only and all allowing the commander to select which style suited them best.

eyeonus commented 6 years ago

Those are certainly useful, but the implementation....

I would think it'd be easier to just allow naming ship profiles, which would allow individuals to have as many or few "extra" ships as desired, simply by putting in a new name and clicking save, somewhat like TDH1 did, although with just ships and not everything.

On Thu, Sep 13, 2018, 05:35 MarkAusten notifications@github.com wrote:

For you, none at all. For me, well I use the owned ships as a "bookmark" to my owned ships and use the other list for "what-if' scenarios without my having to write down my ship settings and then reset them once I've done the what-if stuff.

Another commander I've been taking with uses the non-owned ships for doing trade calculations for other commanders with whom he plays Elite, meaning that he can do these without disturbing his own ship values.

I'd guess that you would probably be happy with a single nondescript entry (default) that could be used as you wished and in future I may make the whole ship thing work that way. In the settings there would be a choice of minimal, owned only, bare-ship only and all allowing the commander to select which style suited them best.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/MarkAusten/TDHelper/issues/39#issuecomment-420976122, or mute the thread https://github.com/notifications/unsubscribe-auth/ABpz4NHRjHoocvm635zLLOW9jeb3QWmdks5uakMKgaJpZM4WmbT9 .

MarkAusten commented 6 years ago

Fixed for version v.2.0.8.3