search

MarkAusten / TDHelper

GUI for Trade Dangerous and EDDBlink
MIT License
7 stars 4 forks source link

Laden / unladen jump range values #49

Closed DustRaven closed 5 years ago

DustRaven commented 5 years ago

Getting an error because the values from edmc are incorrectly formatted:

https://gist.github.com/DustRaven/57787366d4f94165087c5283070792b2

MarkAusten commented 5 years ago

Not entirely sure about this since. EDMC is not used by TDH2 and the jump ranges are not found in the profile returned from the Companion API by the EDAPI plugin. These values are manually entered and stored in the correct format in the TDH.ini file and so should not need to be adjusted.

DustRaven commented 5 years ago

Well, if you started the program before, it's fine... But on the first launch it produces the linked error. If i got this right, it's because in the initial setup, when the list of ships is filled, the standard jump range is written as an integer value (ie 975 instead of 9,75) and then it's not converted and gives the above error for ships that have a jump range above 1000, as this is the maximum value for the numeric up/down field. Granted, it's a cosmetical thing, but i just thought it could be remedied :)

MarkAusten commented 5 years ago

I'll see if I can reproduce this but if it is as you say, then it is the fault of the initial setup of the ships and not the code that you have modified. If I merge your code then each time TDH2 is opened the values will become 100 times smaller.

Anyway, I'll look at it and correct it.

Thanks for the additional information