MarkBind / markbind

MarkBind is a tool for generating content-heavy websites from source files in Markdown format
https://markbind.org/
MIT License
136 stars 124 forks source link

Add ability to configure modal scrollbar position #2327

Open tlylt opened 1 year ago

tlylt commented 1 year ago

Please confirm that you have searched existing issues in the repo

Yes, I have searched the existing issues

Any related issues?

2322

What is the area that this feature belongs to?

Other

Is your feature request related to a problem? Please describe.

Currently, we experience a problem of unexpectedly closing the modal window when clicking on the scrollbar (if the scrollbar is outside of the modal). PR #2322 moves the scrollbar into the modal window, hence resolving the issue. However, we should explore supporting both modes if possible.

Describe the solution you'd like

https://github.com/MarkBind/markbind/pull/2322#issuecomment-1632737944

Describe alternatives you've considered

This might become a non-issue if we migrate to Vue 3 and upgrade our vue-final-modal version to latest.

Additional context

No response

jmestxr commented 1 year ago

To move the scrollbar out of the modal, we could add the following to the existing .vfm--inset class to allow the outer modal container to overflow:

.vfm--inset {
      overflow-y: scroll;
}

and remove max-height: 100%; from .modal-content.

tlylt commented 1 year ago

To move the scrollbar out of the modal, we could add the following to the existing .vfm--inset class to allow the outer modal container to overflow:

.vfm--inset {
      overflow-y: scroll;
}

and remove max-height: 100%; from .modal-content.

Does this solution work without resulting in the same issue that was addressed by #2322 ?

jmestxr commented 1 year ago

Does this solution work without resulting in the same issue that was addressed by #2322 ?

Ah right, I didn't get the full picture of the issue. Can I continue to work on this?

tlylt commented 1 year ago

Does this solution work without resulting in the same issue that was addressed by #2322 ?

Ah right, I didn't get the full picture of the issue. Can I continue to work on this?

Sure, feel free to explore 👍