MarkBind / markbind

MarkBind is a tool for generating content-heavy websites from source files in Markdown format
https://markbind.org/
MIT License
135 stars 124 forks source link

Layout ts #2461

Closed kaixin-hc closed 6 months ago

kaixin-hc commented 6 months ago

What is the purpose of this pull request?

Overview of changes:

Anything you'd like to highlight/discuss:

Testing instructions:

Proposed commit message: (wrap lines at 72 characters)


Checklist: :ballot_box_with_check:


Reviewer checklist:

Indicate the SEMVER impact of the PR:

At the end of the review, please label the PR with the appropriate label: r.Major, r.Minor, r.Patch.

Breaking change release note preparation (if applicable):

Give a brief explanation note about:

  • what was the old feature that was made obsolete
  • any replacement feature (if any), and
  • how the author should modify his website to migrate from the old feature to the replacement feature (if possible).
codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 57.14286% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 48.93%. Comparing base (37d2c18) to head (010d9e1).

Files Patch % Lines
packages/core/src/Layout/Layout.ts 46.15% 7 Missing :warning:
packages/core/src/Layout/LayoutManager.ts 50.00% 7 Missing :warning:
packages/core/src/Page/index.ts 25.00% 3 Missing :warning:
packages/core/src/Site/index.ts 75.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2461 +/- ## ========================================== + Coverage 48.90% 48.93% +0.02% ========================================== Files 124 124 Lines 5247 5250 +3 Branches 1112 1112 ========================================== + Hits 2566 2569 +3 - Misses 2373 2376 +3 + Partials 308 305 -3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.