Closed yiwen101 closed 3 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 51.11%. Comparing base (
e95e588
) to head (d86cc3f
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@yiwen101 Could you also remove the .js file in this PR? When pulling your branch I still see it
@yiwen101 Could you also remove the .js file in this PR? When pulling your branch I still see it
Thanks for pulling my branch to test it. It is removed(renamed). I think you still see it because the js file is ignored due to gitignore?
What is the purpose of this pull request?
Overview of changes: Mostly some type cleaning and method arguments alignment. Working on #1913.
Anything you'd like to highlight/discuss:
Testing instructions:
Proposed commit message: (wrap lines at 72 characters) Migrate Site.test to Typescript
Checklist: :ballot_box_with_check:
Reviewer checklist:
Indicate the SEMVER impact of the PR:
At the end of the review, please label the PR with the appropriate label:
r.Major
,r.Minor
,r.Patch
.Breaking change release note preparation (if applicable):