Closed yiwen101 closed 3 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 51.11%. Comparing base (
c268733
) to head (370b3ba
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@yiwen101 - please revert the merge commit 😅
@yiwen101 - please revert the merge commit 😅
sorry, I must have accidentally hit "update with merge" someday😅.
LGTM!
@itsyme Each PR must have a SEMVER impact label, please remember to label the PR properly.
What is the purpose of this pull request?
Overview of changes: Working on #1913; quite trivial changes.
Anything you'd like to highlight/discuss:
Testing instructions:
Proposed commit message: (wrap lines at 72 characters) Migrate core/index.js to Typescript
Checklist: :ballot_box_with_check:
Reviewer checklist:
Indicate the SEMVER impact of the PR:
At the end of the review, please label the PR with the appropriate label:
r.Major
,r.Minor
,r.Patch
.Breaking change release note preparation (if applicable):