search

MarkBind / markbind

MarkBind is a tool for generating content-heavy websites from source files in Markdown format
https://markbind.org/
MIT License
134 stars 123 forks source link

Add a reminder when contributor is new to ping all contributor bot #2484

Closed KevinEyo1 closed 2 months ago

KevinEyo1 commented 3 months ago

What is the purpose of this pull request?

Overview of changes: Fixes #2457 Added workflow to check on merge whether pr author is new to the repo, and ping a reminder to add them to contributors list

Anything you'd like to highlight/discuss:

Testing instructions: test repo 1) Fork this repo and make any change and push it. 2) Create a PR 3) I can merge it and new contributor message pops up 4) Repeat steps 1 and 2 5) I can merge it and no more new contributor message pops up

Proposed commit message: (wrap lines at 72 characters) GitHub Actions: ping new contributor

It is easy to forget to add new contributors.

Adding a workflow to automate reminders to add will help.

Let's on merge, check whether PR author has a prior merged PR, pinging them if not since they are a new contributor.

This approach allows the user to remember to ask to be added to the contributor list, if they want to.

Checklist: :ballot_box_with_check:

Reviewer checklist:

Indicate the SEMVER impact of the PR:

At the end of the review, please label the PR with the appropriate label: r.Major, r.Minor, r.Patch.

Breaking change release note preparation (if applicable):

Give a brief explanation note about:

  • what was the old feature that was made obsolete
  • any replacement feature (if any), and
  • how the author should modify his website to migrate from the old feature to the replacement feature (if possible).
codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 51.00%. Comparing base (362f761) to head (7c00b6e).

:exclamation: Current head 7c00b6e differs from pull request most recent head 03bde6f. Consider uploading reports for the commit 03bde6f to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2484 +/- ## ======================================= Coverage 51.00% 51.00% ======================================= Files 124 124 Lines 5384 5384 Branches 1162 1162 ======================================= Hits 2746 2746 Misses 2348 2348 Partials 290 290 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

yucheng11122017 commented 3 months ago

Hi @KevinEyo1 thanks for the work! Could you also include some test workflows for us to check if its ok?

KevinEyo1 commented 3 months ago

Hi @yucheng11122017 I'm still working on the testing and fixing bugs, I will add the test workflows when I set this PR to ready for review.

yucheng11122017 commented 3 months ago

Hi @KevinEyo1 thanks for the work! Could you also include some test workflows for us to check if its ok?

KevinEyo1 commented 3 months ago

Thanks to @yucheng11122017 for helping me test this. ~~Test workflow: 1st time, new contributor, message pops up on merge 2nd time, not new contributor, no message pops up on merge~~

KevinEyo1 commented 3 months ago

Test run to check time

KevinEyo1 commented 3 months ago

Hi @kaixin-hc, those are some good points. Can I just clarify what you mean by welcoming them more?

kaixin-hc commented 3 months ago

It's an open-ended thought - looking for ideas. I think more encouragement early on can be good for newer contributors? But I'm also not certain on implementation

KevinEyo1 commented 3 months ago

Test workflow: 1st time, new contributor, message pops up on merge 2nd time, not new contributor, no message pops up on merge

github-actions[bot] commented 2 months ago

@yucheng11122017 Each PR must have a SEMVER impact label, please remember to label the PR properly.