MarkBind / markbind

MarkBind is a tool for generating content-heavy websites from source files in Markdown format
https://markbind.org/
MIT License
134 stars 123 forks source link

Fix stray space before popover and tooltip #2486

Closed yiwen101 closed 3 months ago

yiwen101 commented 3 months ago

What is the purpose of this pull request?

Overview of changes: Resolve #2419, modified vue(modification made at minimal scope via trial and error) and add test; Credit to @kaixin-hc for investigating the cause of the bug.

Anything you'd like to highlight/discuss:

Testing instructions: Test with markbind serve -d

Proposed commit message: (wrap lines at 72 characters) Fix stray space before popover and tooltip


Checklist: :ballot_box_with_check:


Reviewer checklist:

Indicate the SEMVER impact of the PR:

At the end of the review, please label the PR with the appropriate label: r.Major, r.Minor, r.Patch.

Breaking change release note preparation (if applicable):

Give a brief explanation note about:

  • what was the old feature that was made obsolete
  • any replacement feature (if any), and
  • how the author should modify his website to migrate from the old feature to the replacement feature (if possible).
codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 51.11%. Comparing base (cab80b7) to head (cbe3ede).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2486 +/- ## ======================================= Coverage 51.11% 51.11% ======================================= Files 124 124 Lines 5355 5355 Branches 1152 1152 ======================================= Hits 2737 2737 Misses 2328 2328 Partials 290 290 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tlylt commented 3 months ago

as I think that future devs may be confuse why there is a comment there

I agree, not obvious and could be accidentally deleted in the future. @yiwen101 could you note the reason inside the comment pls?

yiwen101 commented 3 months ago

@tlylt @EltonGohJH Thank you for the valuable suggestions. I have improve the comment.

github-actions[bot] commented 3 months ago

@kaixin-hc Each PR must have a SEMVER impact label, please remember to label the PR properly.