Closed yiwen101 closed 3 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 51.11%. Comparing base (
cab80b7
) to head (cbe3ede
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
as I think that future devs may be confuse why there is a comment there
I agree, not obvious and could be accidentally deleted in the future. @yiwen101 could you note the reason inside the comment pls?
@tlylt @EltonGohJH Thank you for the valuable suggestions. I have improve the comment.
@kaixin-hc Each PR must have a SEMVER impact label, please remember to label the PR properly.
What is the purpose of this pull request?
Overview of changes: Resolve #2419, modified vue(modification made at minimal scope via trial and error) and add test; Credit to @kaixin-hc for investigating the cause of the bug.
Anything you'd like to highlight/discuss:
Testing instructions: Test with
markbind serve -d
Proposed commit message: (wrap lines at 72 characters) Fix stray space before popover and tooltip
Checklist: :ballot_box_with_check:
Reviewer checklist:
Indicate the SEMVER impact of the PR:
At the end of the review, please label the PR with the appropriate label:
r.Major
,r.Minor
,r.Patch
.Breaking change release note preparation (if applicable):