Fix imported modal button position off

[yiwen101]

What is the purpose of this pull request?

• [ ] Documentation update
• [x] Bug fix
• [ ] Feature addition or enhancement
• [ ] Code maintenance
• [ ] DevOps
• [ ] Improve developer experience
• [ ] Others, please explain:

Overview of changes: Fixes #2473 Credit to @tlylt for all the work and investigation; the actual fix code is trivial.

Anything you'd like to highlight/discuss:

Testing instructions: test with markbind serve -d

Proposed commit message: (wrap lines at 72 characters) Fix off-positioned close button in imported modal

---

Checklist: :ballot_box_with_check:

• [ ] Updated the documentation for feature additions and enhancements
• [ ] Added tests for bug fixes or features
• [x] Linked all related issues
• [x] No unrelated changes

---

Reviewer checklist:

Indicate the SEMVER impact of the PR:

• [ ] Major (when you make incompatible API changes)
• [ ] Minor (when you add functionality in a backward compatible manner)
• [x] Patch (when you make backward compatible bug fixes)

At the end of the review, please label the PR with the appropriate label: r.Major, r.Minor, r.Patch.

Breaking change release note preparation (if applicable):

• To be included in the release note for any feature that is made obsolete/breaking

Give a brief explanation note about:

• what was the old feature that was made obsolete
• any replacement feature (if any), and
• how the author should modify his website to migrate from the old feature to the replacement feature (if possible).

[yucheng11122017]

Hi @yiwen101 I think you shouldn;t be commiting the changes in the binary files

[yiwen101]

Hi @yiwen101 I think you shouldn;t be commiting the changes in the binary files

Thanks, will revert the result of npm run build:web

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 51.14%. Comparing base (574e800) to head (7ac9991).

:exclamation: Current head 7ac9991 differs from pull request most recent head 8940f7f. Consider uploading reports for the commit 8940f7f to get more accurate results

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #2487 +/- ## ========================================== + Coverage 51.00% 51.14% +0.14% ========================================== Files 124 124 Lines 5384 5359 -25 Branches 1162 1152 -10 ========================================== - Hits 2746 2741 -5 + Misses 2348 2328 -20 Partials 290 290 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[yiwen101]

Could you add a functional test for testing the behaviour described in the issue? If you can do a unit test, would be even better but might be a bit tough

Sorry for the late reply. I have added the functional test. To verify the result of fix, remember to do "markbind serve -d", otherwise the position will still be off(since frontend is updated per release).

[yiwen101]

LGTM!

The language for commit message seems off. how bout Fix off-positioned close button in imported modal

Thanks for the review and suggestions on the commitment message. Yes, the suggested commit message is clearer. I have also updated the "proposed commit message" for this PR accordingly.