Closed yiwen101 closed 3 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 51.08%. Comparing base (
147899a
) to head (7c635bd
).:exclamation: Current head 7c635bd differs from pull request most recent head 1e473bd. Consider uploading reports for the commit 1e473bd to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks for attempting this @yiwen101 This will be a good addition to the different icon sets we support.
@yucheng11122017 Each PR must have a SEMVER impact label, please remember to label the PR properly.
Feature in action https://nus-cs2103-ay2324s2.github.io/website/admin/tp-w9.html
What is the purpose of this pull request?
Overview of changes: Support bootstrap icons #1977
Anything you'd like to highlight/discuss: I need to upload the copy of bootstrap-icons to the expected folder to pass test (and in current code, the expected folder also contains the source code of all other icons supported) That is where the +50 000 comes from.
Testing instructions:
Proposed commit message: (wrap lines at 72 characters) Support Bootstrap icons
Checklist: :ballot_box_with_check:
Reviewer checklist:
Indicate the SEMVER impact of the PR:
At the end of the review, please label the PR with the appropriate label:
r.Major
,r.Minor
,r.Patch
.Breaking change release note preparation (if applicable):