1697

Changed the seamless panels so that the background is transparent and it inherits the colours of any parents its contained in.

Anything you'd like to highlight/discuss: As pointed out in the issue, this might break some edge cases (e.g. a seamless panel in a <box background-color="black" color="black"> box).

Testing instructions: I've added some examples in the userguide to show the new look. markbind serve -d the docs to see the changes and try out different cases to see if it works or if there's any improvements.

Proposed commit message: (wrap lines at 72 characters) Change seamless panels to inherit colours of any parents

Checklist: :ballot_box_with_check:

[ ] Updated the documentation for feature additions and enhancements
[ ] Added tests for bug fixes or features
[x] Linked all related issues
[x] No unrelated changes

Reviewer checklist:

Indicate the SEMVER impact of the PR:

[ ] Major (when you make incompatible API changes)
[ ] Minor (when you add functionality in a backward compatible manner)
[x] Patch (when you make backward compatible bug fixes)

At the end of the review, please label the PR with the appropriate label: r.Major, r.Minor, r.Patch.

Breaking change release note preparation (if applicable):

To be included in the release note for any feature that is made obsolete/breaking

Give a brief explanation note about:

what was the old feature that was made obsolete

any replacement feature (if any), and

how the author should modify his website to migrate from the old feature to the replacement feature (if possible).

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 51.02%. Comparing base (fc776ba) to head (a721356).

:exclamation: Current head a721356 differs from pull request most recent head b075167. Consider uploading reports for the commit b075167 to get more accurate results

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #2501 +/- ## ========================================== + Coverage 50.99% 51.02% +0.02% ========================================== Files 124 124 Lines 5383 5372 -11 Branches 1160 1159 -1 ========================================== - Hits 2745 2741 -4 + Misses 2348 2341 -7 Partials 290 290 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jingting1412 commented 3 months ago

Idk how my other allocate space for scrollbar commit got here 😞 but the changed files only reflect the changes relevant to this pr!

kaixin-hc commented 3 months ago

Weird that the netlify deploy preview failed. Maybe it will fix itself on push

damithc commented 2 months ago

Feature in action https://nus-cs2103-ay2324s2.github.io/website/schedule/week8/topics.html

MarkBind / markbind

Change seamless panels to inherit any parent's colours #2501

1697

Codecov Report