Closed KevinEyo1 closed 5 months ago
Test ci.yml: Passes tests Test description body: Removed description, check runs and fails. Add back and check runs and passes. Test PR Merge Updated job runs No impact selected and fails 2 impacts selected and fails r.Major selected and passes
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 51.00%. Comparing base (
ff8e9b1
) to head (8b185c3
).:exclamation: Current head 8b185c3 differs from pull request most recent head b199f86. Consider uploading reports for the commit b199f86 to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
What is the purpose of this pull request?
Overview of changes: Fixes #2488 Refactor code and improve security of workflows based on research on security best practices
Anything you'd like to highlight/discuss: Removed explicit stating of
GITHUB_TOKEN
inci.yml
, not sure if there is a need for it as there is no documentation of why it was added.Testing instructions:
Proposed commit message: (wrap lines at 72 characters) GitHub Actions: improve security
Security best practices need to be enforced to ensure no avenues of attack and security breaches.
Let's update the workflows following security best practices, particularly restricting permissions to read permissions
Checklist: :ballot_box_with_check:
Reviewer checklist:
Indicate the SEMVER impact of the PR:
At the end of the review, please label the PR with the appropriate label:
r.Major
,r.Minor
,r.Patch
.Breaking change release note preparation (if applicable):