MarkBind / markbind

MarkBind is a tool for generating content-heavy websites from source files in Markdown format
https://markbind.org/
MIT License
134 stars 123 forks source link

Move buggy bootstrap-icons dependency to core/package.json #2539

Closed kaixin-hc closed 2 months ago

kaixin-hc commented 2 months ago

What is the purpose of this pull request?

Addresses #2538

Overview of changes: Moving of the dependency. The file packages/core/package.json is also where the other icon dependencies live.

Anything you'd like to highlight/discuss: See comments on issue. Also, testing may be misleading CI passing, local passing even with the erroneous code, and some websites deploying fine on 5.5.0 (eg markbind website).

Also, I have no idea why that last bracket is marked as a change. It looks the same to me???

Testing instructions: Ideas on how else to test appreciated.

Reproducing issue notes:

  1. You can verify this issue exists locally by making sure you are using the npm installed version and that you have no other markbind on your device + markbind is not npm linked to your local development repository
  2. When I linked to markbind 5.5.0 locally, this crashes... until I ran npm setup, which made all sites work

Testing this PR:

  1. Locally, npm run setup after these changes results in the local sites working 😓 😅

Proposed commit message: (wrap lines at 72 characters) Move buggy bootstrap-icons dependency to core/package.json


Checklist: :ballot_box_with_check:


Reviewer checklist:

Indicate the SEMVER impact of the PR:

At the end of the review, please label the PR with the appropriate label: r.Major, r.Minor, r.Patch.

Breaking change release note preparation (if applicable):

Give a brief explanation note about:

  • what was the old feature that was made obsolete
  • any replacement feature (if any), and
  • how the author should modify his website to migrate from the old feature to the replacement feature (if possible).
damithc commented 2 months ago

Thanks for the quick fix @kaixin-hc

yiwen101 commented 2 months ago

LGTM Thank you for the quick investigation and fix