Overview of changes:
Moving of the dependency. The file packages/core/package.json is also where the other icon dependencies live.
Anything you'd like to highlight/discuss:
See comments on issue. Also, testing may be misleading CI passing, local passing even with the erroneous code, and some websites deploying fine on 5.5.0 (eg markbind website).
Also, I have no idea why that last bracket is marked as a change. It looks the same to me???
Testing instructions:
Ideas on how else to test appreciated.
Reproducing issue notes:
You can verify this issue exists locally by making sure you are using the npm installed version and that you have no other markbind on your device + markbind is not npm linked to your local development repository
When I linked to markbind 5.5.0 locally, this crashes... until I ran npm setup, which made all sites work
Testing this PR:
Locally, npm run setup after these changes results in the local sites working 😓 😅
Proposed commit message: (wrap lines at 72 characters)
Move buggy bootstrap-icons dependency to core/package.json
Checklist: :ballot_box_with_check:
[ ] Updated the documentation for feature additions and enhancements
What is the purpose of this pull request?
Addresses #2538
Overview of changes: Moving of the dependency. The file packages/core/package.json is also where the other icon dependencies live.
Anything you'd like to highlight/discuss: See comments on issue. Also, testing may be misleading CI passing, local passing even with the erroneous code, and some websites deploying fine on 5.5.0 (eg markbind website).
Also, I have no idea why that last bracket is marked as a change. It looks the same to me???
Testing instructions: Ideas on how else to test appreciated.
Reproducing issue notes:
Testing this PR:
Proposed commit message: (wrap lines at 72 characters) Move buggy bootstrap-icons dependency to core/package.json
Checklist: :ballot_box_with_check:
Reviewer checklist:
Indicate the SEMVER impact of the PR:
At the end of the review, please label the PR with the appropriate label:
r.Major
,r.Minor
,r.Patch
.Breaking change release note preparation (if applicable):