Closed kaixin-hc closed 2 months ago
What is the purpose of this pull request?
Overview of changes: Bumping the version. This issue states it is resolved in 6.5. package-lock in a separate PR has to be bumped now to pass CI which uses npm CI
Anything you'd like to highlight/discuss: The changes in test files are expected - see this PR https://github.com/MarkBind/markbind/pull/2326 .
Testing instructions:
Before:
After:
Proposed commit message: (wrap lines at 72 characters) Bump fontawesome to remove console error(#2540)
Checklist: :ballot_box_with_check:
Reviewer checklist:
Indicate the SEMVER impact of the PR:
At the end of the review, please label the PR with the appropriate label: r.Major, r.Minor, r.Patch.
r.Major
r.Minor
r.Patch
Breaking change release note preparation (if applicable):
Give a brief explanation note about: what was the old feature that was made obsolete any replacement feature (if any), and how the author should modify his website to migrate from the old feature to the replacement feature (if possible).
Give a brief explanation note about:
What is the purpose of this pull request?
Overview of changes: Bumping the version. This issue states it is resolved in 6.5. package-lock in a separate PR has to be bumped now to pass CI which uses npm CI
Anything you'd like to highlight/discuss: The changes in test files are expected - see this PR https://github.com/MarkBind/markbind/pull/2326 .
Testing instructions:
Before:
After:
Proposed commit message: (wrap lines at 72 characters) Bump fontawesome to remove console error(#2540)
Checklist: :ballot_box_with_check:
Reviewer checklist:
Indicate the SEMVER impact of the PR:
At the end of the review, please label the PR with the appropriate label:
r.Major
,r.Minor
,r.Patch
.Breaking change release note preparation (if applicable):