search

MarkDHamill / smartfeed

Smartfeed Extension for phpBB
GNU General Public License v2.0
1 stars 2 forks source link

Potential issues on phpBB 3.2 #2

Closed JoshyPHP closed 6 years ago

JoshyPHP commented 6 years ago

In phpBB 3.2, the posts' text is stored as XML. If you want to modify a post's HTML, it should be done after the post has been rendered with generate_text_for_display().

In this block, censor_text() is run on the original XML before it is rendered to HTML.

In this block, both censor_text() and create_attachment_markup() are used on the XML. Those should be moved down after generate_text_for_display() has been run. Also, generate_text_for_display() already censors the HTML so you shouldn't have to run it manually beforehand.

This may be the cause of this issue.

SpIdErPiGgY1984 commented 6 years ago

Problem solved. Thank you! :) https://www.phpbb.com/community/viewtopic.php?f=556&t=2474556#p15029846