phpBB 3.2 compliance - Githubissues

BmdOnline commented 6 years ago

Hi, According to phpBB 3.2, you may change your template file overall_header_navigation_prepend.html

Now, you are using :

<li class="small-icon icon-smartfeed no-bulletin"><a href="{{ U_SMARTFEED_PAGE }}">{{ lang('SMARTFEED_PAGE') }}</a></li>

I think it would be better to use :

      <li data-last-responsive="true">
          <a href="{U_SMARTFEED_PAGE}" title="{L_SMARTFEED_PAGE}" role="menuitem">
              <i class="icon fa-rss fa-fw" aria-hidden="true"></i><span>{L_SMARTFEED_PAGE}</span>
          </a>
      </li>

This is same format as navbar_header.html and avoid icon_mini_feed.gif (you can remove it). So, it works with all templates (using fontawesome).

MarkDHamill commented 6 years ago

You are quite right about this. With phpBB 3.2, FontAwesome is supported so this is a much better way to go. It will show up in the next version.

MarkDHamill commented 5 years ago

Fixed in version 3.2.10.

MarkDHamill / smartfeed

phpBB 3.2 compliance #3