search

MarkDHamill / smartfeed

Smartfeed Extension for phpBB
GNU General Public License v2.0
1 stars 2 forks source link

Querying only first posts yields an SQL error #4

Open desertkun opened 3 years ago

desertkun commented 3 years ago

See this live example: https://spectrumcomputing.co.uk/forums/app.php/smartfeed/feed?u=1360&e=hh8v0WVJXxmAl3zq7nWRsS50DqM3vdO2VbkSFeNs3rnNfgjpNTc6uSOmot707klsATgDEzhs4hMBE8oso2dNwwUvB5r2xqtC966COhuG1B4.&l=1&fp=1&t=1&x=25&s=0&i=0&y=0&d=3&w=0

I have configured Types of posts in feed to be First posts of topics only. Doing the same with last posts, surprisingly, works.

MarkDHamill commented 3 years ago

Thanks. Line 393 in /controller/feed.php should be:

$new_topics_sql = " AND t.topic_time > $this->time_limit ";

$this->date_limit is an obsolete private variable.

All instances of $this->date_limit in feed.php should be replaced with $this->time_limit.

Will be fixed in next version.

desertkun commented 3 years ago

Thanks. Looking forward in the upcoming release!