search

MarkDurbin104 / 3dp.rocks

All source from 3DP.Rock website and blog
MIT License
103 stars 58 forks source link

Gettext #2

Closed ingegno closed 9 years ago

ingegno commented 9 years ago

This patch is to add I18n as talked about in https://github.com/MarkDurbin104/3dp.rocks/issues/1 It should change nothing to the English version, it just makes translation easy, and adds already a Dutch translation.

I looked over possibilities, and although it seems overkill went for a gettext solution. This gives reextract of changed strings in a po template lithophane.pot, merge of translations, ... I selected to do it with Jed as it seems popular and well supported.

For how to add other translations, see Readme.md in the locales directory.

It would be nice to perhaps add a dropdown to select language, but as these are my first steps in javascript, I don't want to overreach. And I don't know if you would want that :-)

ingegno commented 9 years ago

I see when comparing my local version with official version that after this patch the Curve dropdown has the same size as the input fields above it. In official version this is not the case. I have no idea what the reason of that could be. It does not look bad though.