Make new compatible with old

MarkEdmondson1234 commented 6 years ago

I have existing apps and tutorials out there using some of the older functions, so I need to make sure there is at least a deprecation notice on the functions with a suggestion on what to do instead before it hits CRAN.

For example this app should work https://github.com/MarkEdmondson1234/verbal_ga_shiny/blob/master/app_final.R

Missing functions currently include:

graph_box(boxtitle = "Google Analytics Data",
            subtitle = "Trend",
            dygraphOutput("trend_plot"),
            datepicker = dateRangeInput("datepicker", NULL, start = Sys.Date() - 300))

and

dashboard_box(width = 12, textOutput("text_analysis"), box_title = "Transcript")

Also need to make sure the tracking tags are enabled, which is essential for my live deployed apps, so incorporating this function into the footer somewhere: https://github.com/MarkEdmondson1234/gentelellaShiny/blob/802eea1318c2a1eb1fe1507c1b26f550bf051503/R/template.R#L20

MarkEdmondson1234 commented 6 years ago

I renamed the new function to gentelellaPageCustom() - there are too many video tutorials and apps using the old function to make it a smooth transition, I will spend the rest of my years supporting them :)

But all the new functionality is all in there, just with renamed function. The old function is quicker to get up and running I think, whilst the new one offers more power and control. Will look at integrating more of the HTML/CSS as I'm sure there are some redundant functions.

DivadNojnarg commented 6 years ago

Hi Mark, I missed your message. I agree with your new approach, even though I would have prefered the name gentelellaPagePlus() instead of gentelellaPageCustom(). What do you think about that? Let me know if you need some help for special tasks.

MarkEdmondson1234 commented 6 years ago

Sure that’s no problem.

MarkEdmondson1234 / gentelellaShiny

Make new compatible with old #3