search

MarkEdmondson1234 / googleAuthR

Google API Client Library for R. Easy authentication and help to build Google API R libraries with OAuth2. Shiny compatible.
https://code.markedmondson.me/googleAuthR
Other
175 stars 54 forks source link

Don't init .auth object until .onLoad #195

Closed jcheng5 closed 3 years ago

jcheng5 commented 3 years ago

Creating the .auth object directly at the top-level means the code from gargle is snapshotted at build time.

This is needed for r-lib/gargle#157, but is a good change even without that PR.

jcheng5 commented 3 years ago

@jennybc I hope I didn't jump the gun with these PRs? Does this look good to you?

jennybc commented 3 years ago

With the caveat that my head is elsewhere, yes looks good to me.

MarkEdmondson1234 commented 3 years ago

Thanks, I saw the conversation on gargle and was wondering how it would affect here. I'll test this with a few downstream packages.