Open muschellij2 opened 3 years ago
Not necessarily as I for instance have a service email that is added to several GCP projects. It could perhaps be a helpful default though as perhaps I'm using it in an edge case.
It may be good to add GOOGLE_APPLICATION_CREDENTIALS
as that's the recommended way to set up for gloud SDK according to:
https://cloud.google.com/docs/authentication/getting-started#setting_the_environment_variable
If you have
GCE_AUTH_FILE
then it should be able to extract theproject_id
, which may be less prone to errors (e.g. difference between project_name and project_id) than forcing people to set the ID:I'm suggesting editing: https://github.com/MarkEdmondson1234/googleCloudRunner/blob/b4a2b1f3062f7f57ca4b0205f58dfa0342b17212/R/init.R#L70
I think it could be something like this:
This would swap out the ordering likely from https://github.com/MarkEdmondson1234/googleCloudRunner/blob/b4a2b1f3062f7f57ca4b0205f58dfa0342b17212/R/setup.R#L38