search

MarkEdmondson1234 / googleCloudRunner

Easy R scripts on Google Cloud Platform via Cloud Run, Cloud Build and Cloud Scheduler
https://code.markedmondson.me/googleCloudRunner/
Other
81 stars 26 forks source link

cr_build_wait shows wrong percentage done relative to timeout #147

Open brancengregory opened 2 years ago

brancengregory commented 2 years ago

The percent done relative to timeout is off by a factor of five. So it shows 20% when build time has in fact reached 100% of timeout.

My intuition says that this has to do with the Sys.sleep(5) call and/or the spinner initialization in R/build_admin.R, however I don't know how to go about fixing it efficiently.

Feel free to give me a pointer if you don't have the time to fix. I want to familiarize myself with this codebase because I think it is brilliant and hope to contribute at some point.

MarkEdmondson1234 commented 2 years ago

Hmm that's annoying! I added the timer last release using cli tools. You are very welcome to take a look, it's in https://github.com/MarkEdmondson1234/googleCloudRunner/blob/master/R/build_admin.R the wait_f does the ticks.

brancengregory commented 2 years ago

Excellent, thanks, I'll give it a go!