search

MarkEdmondson1234 / googleCloudRunner

Easy R scripts on Google Cloud Platform via Cloud Run, Cloud Build and Cloud Scheduler
https://code.markedmondson.me/googleCloudRunner/
Other
81 stars 26 forks source link

added in the docker auth function to export #158

Closed muschellij2 closed 2 years ago

muschellij2 commented 2 years ago

Tidied up a few things with the target that were failiing R CMD check and exported the docker auth step as it is useful for some most likely.

muschellij2 commented 2 years ago

I've also added the ability for cr_deploy_docker_construct (and therefore cr_deploy_docker) to pass relevant argument to cr_build_yaml in case you need to add options/substitutions/etc

muschellij2 commented 2 years ago

I have run into issues with calling docker_auth explicitly now, so I don't think we need to do that given the new docker images from GCP builders

muschellij2 commented 2 years ago

This should now pass all checks except for the linter and CodeFactor as it seems as though codefactor is reaading roxygen2 headers and failing and linter has some collation issues and some other warnings that are not real fails.

MarkEdmondson1234 commented 2 years ago

@muschellij2 this is a super monster pull request now, I suggest we close this one, you can merge with CRAN version then we can target smaller pull requests to get them in next release.

muschellij2 commented 2 years ago

I am relying on this for my pipelines because of the issues that arise in this PR. What would you suggest with the splits? We may just simply have to maintain our own branch due to the number of issues that arose.

MarkEdmondson1234 commented 2 years ago

The best way to get the pull quickly merged will be: