MarkEdmondson1234 / googleCloudRunner

Easy R scripts on Google Cloud Platform via Cloud Run, Cloud Build and Cloud Scheduler
https://code.markedmondson.me/googleCloudRunner/
Other
82 stars 26 forks source link

BuildTrigger removes GCS tarball source #167

Open muschellij2 opened 2 years ago

muschellij2 commented 2 years ago

When scheduling, if you're using a tar.gz (e.g. from deploy docker), this clears out that source and causes fails: https://github.com/MarkEdmondson1234/googleCloudRunner/blob/master/R/buildtriggers.R#L261

MarkEdmondson1234 commented 2 years ago

This is intentional, as its too confusing having triggers that could be sources (GitHub) have different sources (Cloud Storage). For the new event based buildtriggers the new sourceToBuild field should be used instead.

muschellij2 commented 2 years ago

I guess what I'm saying is that you cannot simply use a (or it's difficult to find and remember which) .tar.gz to assign to this as this was embedded in the build from before. So removing that source now causes a malformed build.

MarkEdmondson1234 commented 2 years ago

May I see an example as this isn't a workflow I'm familiar with - perhaps it needs support or some guide rails preventing it.