search

MarkGodwin / tplink-omada-api

MIT License
16 stars 12 forks source link

Move aiohttp #2

Closed fabaff closed 1 year ago

fabaff commented 1 year ago

aiohttp is a runtime requirement.

MarkGodwin commented 1 year ago

Thanks. Python isn't my language, and this is my first library package so I appreciate the fix. Does this need to be released as v1.0.2? I'm not sure what the impact is of the error.

fabaff commented 1 year ago

For the NixOS package (https://github.com/NixOS/nixpkgs/pull/200935) I added aiohttp. For Home Assistant it's also not an issue as Home Assistant itself will pull in aiohttp. If one want to use the package as standalone module then there will be a traceback.