Closed napulen closed 3 years ago
Great!
Accepting right away, though I see a couple of (potential) issues to review:
Ger7
: Fine if you mean that inversion, but I see lots of them and none of the more usual Ger65
so these might need a review.It
should specify an inversion, usually It6
. It's starting to look like all the Augmented sixths need a simple find/replace.-VII
: generally, replace -
with b
, but actually in so far as these chords appear in minor context, simply VII
will get you a major triad on the lower seventh due to music21 quality
(default) option for handling 6th and 7th degrees in minor. If this proves a more-than-trivial task then the code/anthology.py
script here can help find all and only these cases.Thanks for the review @MarkGotham!
I remember encoding "root position" German Aug6 chords. Some of these should be correct. However, you are right that the number is off. I think I will have to manually inspect all Ger7 chords.
As for It
ones, those are probably incorrect translations of the inversion. Have to look into those.
About the -VII
. Yes, I think most of these could be translated as VII
in When-in-Rome. I have to admit that this one is trickier. **harm
is technically always referring to a harmonic minor scale. When I do the translation, I enforce a harmonic minor interpretation using the arguments in music21.RomanNumeral. Here I am inclined to say that -VII
should always be translated as bVII
because that is the unambiguous translation from **harm. If I understand correctly, this should still refer to the same harmony as VII
in RomanText, correct?
Thanks, great!
And that's right re bVII
-- it should be fine thanks to the cautionary
default that reads this b
and the upper case in the same way.
Generally, many annotations were omitted in the first translation because they were annotated in
part != parts[0]
.This set should have more annotations (and all the previous ones preserved), plus annotations at the pickup measures, which are helpful for alignment.