MarkGotham / When-in-Rome

meta-corpus of and code library for the functional harmonic analysis of music
58 stars 11 forks source link

DCML>RNTXT conversion (bug). 4x fail to load. #81

Open MarkGotham opened 1 year ago

MarkGotham commented 1 year ago

DCML Missing scores

First, the new DCML repos are missing some scores (reported there). Note to self: update when they fill in the gaps.

Conversion from DCML fails

Hi @malcolmsailor . I ran the DMCL-rntxt converter on all the new DCML analyses and have mostly great results. Some exceptions:

Parses and writes fine, but probably warrants a clean up:

Actually fails to parse = 4 cases in total:

Example error message:

malcolmsailor commented 1 year ago

Glad to hear the DCML converter is proving useful!

In the example you gave, it looks like the parser is getting confused by either or both of the "b" and "o" annotations. Presumably, "o" should apply to the chord and not to the 1 figure.

If you want to see if you can patch up the parsing so that it can fix these cases, I have a notebook for comparing DCML and music21 parsings that Johannes made and I further altered. I will send it to you by email.

malcolmsailor commented 1 year ago

The merged PRs https://github.com/cuthbertLab/music21/pull/1635 and https://github.com/cuthbertLab/music21/pull/1634 address two of the 3 bugs causing these issues (see those PRs for more details). The last one is a bug in ms3 that produces negative mc_onset values. @johentsch (not sure why tagging him doesn't seem to be working) said he will fix that.

johentsch commented 1 year ago

Yes tagging works, and the bugs have been fixed (upgrade to the latest ms3). Now, when negative mc_onset values occur it's (most probably) because of an error in the encoding, in which case one needs to find the label (find out where it had correctly been placed) and re-insert it in the correct position. Needless to say, we gladly accept new issues if it occurs in our corpora.

malcolmsailor commented 1 year ago

Yes tagging works

Oh weird... for some reason it wasn't giving me the usual preview that shows that an individual has been tagged. Glad it worked! And thanks for the fix!