MarkGotham / When-in-Rome

meta-corpus of and code library for the functional harmonic analysis of music
58 stars 12 forks source link

Readme download section seems to be out-of-date or incorrect #91

Open malcolmsailor opened 1 year ago

malcolmsailor commented 1 year ago

The readme says:

For downloading a local copy of remote files, see Code.updates_and_checks.remote_scores and the argument convert_and_write_local.

However, there is no function called remote_scores in Code/updates_and_checks.py. There is such a function in Code/collect_convert.py but it appears to be a different function and doesn't have a convert_and_write_local argument. There is a convert_and_write_local function in this second file as well, but there doesn't seem to be an argument by this name anywhere in the code base.

MarkGotham commented 1 year ago

Thanks for catching that. What do you think best for handling this? Perhaps a shared download_from_URL function for 3 different use cases:

  1. test suite: no further action (if the URL works then that's information enough)
  2. write a local copy in original format (.krn, .mscx etc.)
  3. convert to mxl and write a copy