dmcassel
commented
7 years ago I grabbed all countries, so that should only be a problem if someone visits a country that doesn't exist today. With that in mind, would you still prefer it in a branch, or would it be okay on master?
I'd actually prefer if this change would be placed into a branch. If the data-set ever changes, we'd need to make sure to update the countries triple file as well. Also changing this to an 'offline' functionality means that loading a random image for demonstration purposes would not necessarily load the triple for a country (if that country does not exists in the triple file). This is why my preference would be for this change to be outside of the master repo.