MarkMpn / Sql4Cds

SQL 4 CDS core engine and XrmToolbox tool
MIT License
75 stars 22 forks source link

Remove BypassCustomPluginExecution from pre-delete confirmation #390

Closed rajyraman closed 11 months ago

rajyraman commented 11 months ago

If there 10 separate delete statements there will be 10 prompts (if delete count > threshold), just because BypassCustomPluginExecution is checked. So, I have removed this check.

MarkMpn commented 11 months ago

Hi Natraj, thanks for the PR!

This check was in place because bypassing plugins is a potentially dangerous operation, and I forgot that I'd turned that option on once and had to spend a long time putting everything right again.

I appreciate it could be annoying if you have the same message for multiple commands in a row though. I wonder if there is some other approach to still give a warning but make it smoother for the user. Some other possibilities might be:

Let me know what you think!

rajyraman commented 11 months ago

@MarkMpn - Yes to all would be great. But, even in this change it does show that Bypass Plugins are turned on in the confirmation dialog.

MarkMpn commented 11 months ago

Closing this for now as I’ve just merged another change that includes the “yes to all” option, let me know if you want me to revisit this after the next release.

rajyraman commented 11 months ago

@MarkMpn - Thank you 🙏