70 correctly called out that add_compile_options as used in the toolchain wasn't right - as per the documentation "These options are used when compiling targets from the current directory and below" - which means that all targets get the options, even if the target isn't C++. The more correct option is to use CMAKE_LANG_FLAGS_INIT, which allows the toolchain to set the compilation flags for a specific language - in this case CXX.
To help validate, I've added an 'example' project that compiles as C, which should help make sure that C++ options aren't incorrectly picked-up by the C compiler.
70 correctly called out that
add_compile_optionsas used in the toolchain wasn't right - as per the documentation "These options are used when compiling targets from the current directory and below" - which means that all targets get the options, even if the target isn't C++. The more correct option is to useCMAKE_LANG_FLAGS_INIT, which allows the toolchain to set the compilation flags for a specific language - in this caseCXX.To help validate, I've added an 'example' project that compiles as C, which should help make sure that C++ options aren't incorrectly picked-up by the C compiler.