90 identified that the MSVC_TOOLSET_VERSION isn't set when using the Windows.EWDK.toolchain.cmake. It turns out that it's not set when using the Windows.MSVC.toolchain.cmake either.
The toolchain files do set MSVC_VERSION, and that's the problem. By setting MSVC_VERSION, we end-up bypassing CMake's code to automatically set MSVC_TOOLSET_VERSION (and other variables) for us in CMake/Modules/Platform/Windows-MSVC.cmake. Removing the toolchain's code to calculate MSVC_VERSION seems like the right thing to do:
It's less code in the Toolchain files.
It's one fewer processes created during configuration.
90 identified that the
MSVC_TOOLSET_VERSION
isn't set when using theWindows.EWDK.toolchain.cmake
. It turns out that it's not set when using theWindows.MSVC.toolchain.cmake
either.The toolchain files do set
MSVC_VERSION
, and that's the problem. By settingMSVC_VERSION
, we end-up bypassing CMake's code to automatically setMSVC_TOOLSET_VERSION
(and other variables) for us in CMake/Modules/Platform/Windows-MSVC.cmake. Removing the toolchain's code to calculateMSVC_VERSION
seems like the right thing to do: