Different shortcuts on Chrome/FF might make sense

[th0rgall]

Currently the default shortcuts Ctrl + Shift + i and Cmd + Shift + i are used on Mac/Windows/Linux on both FF/Chrome. The reason to use these was that the previous default Cmd/Ctrl + Shift + o was problematic on Windows & Linux (https://github.com/th0rgall/fullscreen/issues/1) .

I did some more research on this:

Cmd/Ctrl + Shift + f seems to be free on Chrome for all platforms.

Arguably, that is the most semantic shortcut because of Fullscreen.

However on Firefox, both Cmd + Shift + F and Cmd + Ctrl + F execute the same built-in fullscreen action (with titlebars shown on mac).

It should be tested, but I think it would be good to have Cmd/Ctrl + Shift + fas a shortcut on Chrome and Cmd/Ctrl + Shift + o on Firefox.

The build process should make such a platform-specific manifest change quite easy.

[MarkTiedemann]

Agreed!

(PS: The reason I initially settled for O was because of the effect that Cmd+Shift+F has on MacOS, animating a tiny window into a full-screen one, e.g.: • -> o -> O. Too bad there's no ▭ on off-the-shelf keyboards...)

[th0rgall]

Oh, okay 😄 Some more stuff: whileCmd + Shift + i works on Chrome (tested locally, new version not yet published on the store), I found this undocumented behavior:

When the fullscreen extension is disabled; Cmd + Shift + i acutally pops up an email window with the current link

However, when the extension is enabled; the extension overrides this and the mail shortcut isn't called.

So no problem now it seems (except if you use the mail shortcut), but another reason to use Cmd + Shift + F / Cmd + Ctrl + F default.

[MarkTiedemann]

Ctrl + Shift + I is problematic with Firefox Developer Edition on Windows - that shortcut is used for "I[nspect]".

EDIT: Also tested with the normal edition, same behavior.