MarkUsProject / Markus

Git repository of MarkUs
MIT License
255 stars 242 forks source link

PDF Zoom and Rotate Functionality #7306

Closed pranavrao145 closed 6 days ago

pranavrao145 commented 1 week ago

Proposed Changes

Closes #5178 by adding zoom and rotate functionality to the PDF viewer in both the Results View and file manager.

Screenshot: image

Type of Change

Type Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
✨ New feature (non-breaking change that adds functionality) X
πŸ› Bug fix (non-breaking change that fixes an issue)
🎨 User interface change (change to user interface; provide screenshots)
♻️ Refactoring (internal change to codebase, without changing functionality)
🚦 Test update (change that only adds or modifies tests)
πŸ“¦ Dependency update (change that updates a dependency)
πŸ”§ Internal (change that only affects developers or continuous integration)

Checklist

Before opening your pull request:

After opening your pull request:

coveralls commented 1 week ago

Pull Request Test Coverage Report for Build 12059555175

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
app/assets/javascripts/Components/Result/pdf_viewer.jsx 18 20 90.0%
<!-- Total: 20 22 90.91% -->
Totals Coverage Status
Change from base Build 11987719101: 0.09%
Covered Lines: 41109
Relevant Lines: 44132

πŸ’› - Coveralls
pranavrao145 commented 1 week ago

Found a tiny UI problem, will fix it and re-submit this PR for review.

EDIT: fixed it!