MarkWheadon / velocity-painting

#VelocityPainting: patterning 3D prints by modulating the print speed
Other
198 stars 31 forks source link

Target speed ignored, rewrites all #22

Open preussja opened 7 years ago

preussja commented 7 years ago

I noticed that my first layer speeds were being rewritten even thought they were different than the target speed. I then sliced a model in S3D, first layer 20mm/sec, bottom half 40 mm/sec and top half 60mm/sec. I set the target speed to 60mm/sec so that only the top half should have been painted. The whole gcode file ended up being painted. I am using the gui 0.5.4, though I think the issue was present earlier.

Archive.zip

MarkWheadon commented 7 years ago

The script is a little dumb at the moment -- whilst it ignores gcode lines with an explicit speed that's not the target speed, it doesn't ignore lines with no speed specified -- and lines with no speed specified use whatever speed was last set. So, you tend to end up with what some people are calling a welding line when the speed isn't the target speed (because the first vector has an explicit speed and so is ignored, but the rest have an implicit speed so they're processed).

There's a need for the script to keep track of the current speed -- when I've done that, we can decide whether stuff at other speeds remains unprocessed, or whether the script should just process everything (thus getting rid of the requirement for it to be sliced at a constant speed, which would make life simpler for everyone).

One reason I haven't made it just process all lines regardless of speed is I need to think of a way of reliably spotting retraction moves, as it wouldn't be right to change put a pattern into those!