search

MarketSquare / Robot-Framework-Mainframe-3270-Library

Test library for Robot Framework to allow interaction with IBM Mainframe 3270.
MIT License
38 stars 18 forks source link

(#103) Provide absolute URLs to files in README #104

Closed robinmatz closed 1 year ago

robinmatz commented 1 year ago

Closes #103

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: -0.03 :warning:

Comparison is base (702dc79) 95.00% compared to head (11907ef) 94.98%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #104 +/- ## ========================================== - Coverage 95.00% 94.98% -0.03% ========================================== Files 4 4 Lines 621 618 -3 Branches 96 92 -4 ========================================== - Hits 590 587 -3 Misses 27 27 Partials 4 4 ``` | Flag | Coverage Δ | | |---|---|---| | acceptance | `81.71% <ø> (-0.09%)` | :arrow_down: | | unit | `88.02% <ø> (-0.06%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#carryforward-flags-in-the-pull-request-comment) to find out more. [see 1 file with indirect coverage changes](https://app.codecov.io/gh/Altran-PT-GDC/Robot-Framework-Mainframe-3270-Library/pull/104/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Harm10 commented 1 year ago

@robinmatz If you make these links absolute they will no longer work on a local clone without internet connection or behind a firewall. I do not see the advantage of making them absolute as their content will be in the clone as well.

robinmatz commented 1 year ago

@Harm10 , the problem is when you try to use these links when on pypi.org.

You can try the link to the contributing guidelines on the page I linked.

You might be right that the links won't work locally without internet. However, as pypi.org might be one place where people find the project for the first time, I think having broken links there is worse to user experience than the problem you mentioned.

Harm10 commented 1 year ago

@robinmatz I see the problem on pypi. But isn't that a problem of pypi itself? BTW the link over there still specifies the typo I corrected: "COUNTRIBUTING.md". So how can that be version 3.2?