MarketSquare / SwingLibrary

Swing UI testing library for Robot Framework
Other
113 stars 68 forks source link

Select Table Cell Area accepting Strings mixes up row and column IDs #166

Open rzezimierz opened 11 months ago

rzezimierz commented 11 months ago

Hello, keyword Select Table Cell Area mixes up arguments provided as strings (check below snippet from TableOperator.java):

    private void selectCellArea(int startRow, int endRow, int startColumn,
            int endColumn) {
        jTableOperator.setRowSelectionAllowed(true);
        jTableOperator.addRowSelectionInterval(startRow, endRow);
        jTableOperator.setColumnSelectionAllowed(true);
        jTableOperator.addColumnSelectionInterval(startColumn, endColumn);
    }

    public void selectCellArea(String startRow, String endRow,
            String startColumn, String endColumn) {
        selectCellArea(Integer.valueOf(startColumn),
                Integer.valueOf(endColumn), Integer.valueOf(startRow),
                Integer.valueOf(endRow));
    }

selectCellArea accepting cell coordinates as strings puts Integer.valueOf(startColumn) into startRow parameter etc.

Best regards, Damian Wojtanowski